-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Density Estimator Class #952
Conversation
@michaeldeistler @janfb this is bare bones at the moment, could use some feedback. Specifically, how much do we want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like the structure. I believe that a more natural file location would be sbi/neural_nets/density_estimators/...
.
Beyond that I made many detailed comments below. Most important would be:
- I do not think that the
FlowDensityEstimator
is working right now because it does not follow the nflows API. - Please write of the
FlowDensityEstimator
, even if they are only API tests.
As for your question: I think the scope of the |
Thanks for the comments! I applied most of the suggestions, but have some questions regarding a couple of your comments, where I could use some extra clarification. |
New PR:
|
Thanks again for the comments! New commit should resolve these.
Once this PR is is merged, we can work on these! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
==========================================
+ Coverage 76.02% 76.08% +0.06%
==========================================
Files 80 83 +3
Lines 6332 6361 +29
==========================================
+ Hits 4814 4840 +26
- Misses 1518 1521 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! 👏
Added another round of comments. Happy to discuss later when we meet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for finishing it. Let's get it merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks a lot!
I think the unticked goals in the PR description can be moved to future PRs / separate issues.
Hello, just a comment that it might be worth adding a By the way, Zuko flows already have an |
fix #932
Goals:
.train()
methods