Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add seeding. #762

Merged
merged 2 commits into from
Nov 2, 2022
Merged

add seeding. #762

merged 2 commits into from
Nov 2, 2022

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Oct 31, 2022 •
edited
Loading

introduces individual seeds for each workers to ensure reproducibility for parallel simulations.

fixes #758

@janfb janfb self-assigned this Oct 31, 2022
@janfb janfb added the enhancement New feature or request label Oct 31, 2022
@janfb janfb force-pushed the fix-simulate-for-sbi-seeding branch 3 times, most recently from ce79cbb to 9497346 Compare October 31, 2022 14:42
@janfb janfb force-pushed the fix-simulate-for-sbi-seeding branch 3 times, most recently from b548803 to 6ad0a5f Compare November 1, 2022 20:11
michaeldeistler
michaeldeistler approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I'd suggest a different name for seed_everything (from the function name, I had expected it to seed all workers, not all backends), otherwise good to go!

sbi/utils/sbiutils.py Outdated Show resolved Hide resolved
@janfb janfb force-pushed the fix-simulate-for-sbi-seeding branch from 6ad0a5f to ae55807 Compare November 2, 2022 12:45
@janfb janfb merged commit fda9d4e into main Nov 2, 2022
@janfb janfb deleted the fix-simulate-for-sbi-seeding branch November 2, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

Assignees

@janfb janfb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paralell simulation with simulatoe_for_sbi is not seeded
2 participants
@janfb @michaeldeistler