-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of TSNPE #754
Conversation
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
- Coverage 74.26% 73.95% -0.32%
==========================================
Files 79 77 -2
Lines 6034 6073 +39
==========================================
+ Hits 4481 4491 +10
- Misses 1553 1582 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks a lot.
I added a couple of comments and questions. I'm wondering about the naming, e.g., replacing threshold
by truncate
because threshold
used as a verb could be a bit unintuitive.
b1584a7
to
87d81a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
9c7b0ea
to
eb24dc8
Compare
eb24dc8
to
264d1a5
Compare
Contributions of this PR
Changes to the code-base
Renamed
rejection_sample_posterior_within_prior
toaccept_reject_sample
since it is more general than to sample the posterior within the prior.API