-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial updates #644
Tutorial updates #644
Conversation
b09de8b
to
1a8d33d
Compare
1a8d33d
to
4b55a1e
Compare
Running slow tests on this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks! just two minor comments.
"source": [ | ||
"import torch\n", | ||
"\n", | ||
"from sbi.inference import SNPE, prepare_for_sbi, simulate_for_sbi\n", | ||
"from sbi.utils.get_nn_models import posterior_nn\n", | ||
"from sbi import utils as utils\n", | ||
"from sbi import analysis as analysis\n", | ||
"torch.manual_seed(0)" | ||
"_ = torch.manual_seed(0)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just torch.manual_seed(0)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torch.manual_seed(0)
returns <torch._C.Generator object at 0x7f10e43d1a90>
which I found a bit ugly in the notebook ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, makes sense then. Alternatively, one could add a ;
at the end of the line, I think.
FCEmbedding
as an optional pre-configured embedding net