Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1260: include points in plotting limits #1265

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Sep 4, 2024

@janfb janfb added the bug Something isn't working label Sep 4, 2024
@janfb janfb self-assigned this Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.29%. Comparing base (becc93c) to head (d03420f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1265       +/-   ##
===========================================
- Coverage   89.24%   78.29%   -10.95%     
===========================================
  Files         119      119               
  Lines        8691     8705       +14     
===========================================
- Hits         7756     6816      -940     
- Misses        935     1889      +954     
Flag Coverage Δ
unittests 78.29% <100.00%> (-10.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/analysis/plot.py 68.46% <100.00%> (-16.26%) ⬇️

... and 32 files with indirect coverage changes

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Quick question below!

sbi/analysis/plot.py Show resolved Hide resolved
@janfb janfb force-pushed the fix-plotting-limits branch 4 times, most recently from 53dbde2 to 15bf836 Compare September 6, 2024 04:59
@janfb janfb requested review from michaeldeistler and removed request for Matthijspals September 6, 2024 05:16
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I would suggest to compute the epsilon range differently, see below. Let's discuss if you disagree!

sbi/analysis/plot.py Outdated Show resolved Hide resolved
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@janfb janfb merged commit b0b5671 into main Sep 9, 2024
6 checks passed
@janfb janfb deleted the fix-plotting-limits branch September 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

points are not included in limits in pairplot
2 participants