Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: score imports #1246

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: score imports #1246

merged 1 commit into from
Aug 29, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Aug 29, 2024

add score classes to init to avoid circular imports.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (b46c7c5) to head (679a8fe).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
- Coverage   86.05%   78.16%   -7.90%     
==========================================
  Files         117      118       +1     
  Lines        8672     8679       +7     
==========================================
- Hits         7463     6784     -679     
- Misses       1209     1895     +686     
Flag Coverage Δ
unittests 78.16% <100.00%> (-7.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/inference/posteriors/score_posterior.py 95.38% <100.00%> (-1.64%) ⬇️
sbi/samplers/score/__init__.py 100.00% <100.00%> (ø)
sbi/samplers/score/score.py 84.90% <100.00%> (-0.28%) ⬇️

... and 27 files with indirect coverage changes

@janfb janfb merged commit bf2f96f into main Aug 29, 2024
6 checks passed
@janfb janfb deleted the fix-score-imports branch August 29, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants