Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python3.8 and torch1.12; update dependencies #1233

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Drop python3.8 and torch1.12; update dependencies #1233

merged 2 commits into from
Aug 27, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Aug 26, 2024

  • fix tests
  • update deps

fixes #1229
fixes #1189
fixes #1150

@janfb janfb force-pushed the fix-tests branch 2 times, most recently from 3e9e71a to 6f84e6f Compare August 26, 2024 07:32
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (b3254ed) to head (ad51ede).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   85.44%   85.35%   -0.09%     
==========================================
  Files         101      101              
  Lines        7941     7956      +15     
==========================================
+ Hits         6785     6791       +6     
- Misses       1156     1165       +9     
Flag Coverage Δ
unittests 85.35% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sbi/analysis/plot.py 70.54% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

@janfb janfb requested a review from michaeldeistler August 26, 2024 10:58
@janfb
Copy link
Contributor Author

janfb commented Aug 26, 2024

TODO:

  • generating the video in 05_conditional_distributions tutorial throws an error: RuntimeError: Requested MovieWriter (ffmpeg) not available. add to dependencies? Or make test "local"
  • type checks failing plotting functions.

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I would suggest we add the MovieWriter to dev dependencies.

pyproject.toml Outdated Show resolved Hide resolved
@janfb janfb force-pushed the fix-tests branch 2 times, most recently from a1376d9 to 2a181aa Compare August 26, 2024 13:57
- add movie writer to dev deps
- downgrade scipy to enable py3.9 support
@janfb janfb merged commit 9648aff into main Aug 27, 2024
7 checks passed
@janfb janfb deleted the fix-tests branch August 27, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants