Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1204: c2st with constant features; fix pyright. #1205

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix #1204: c2st with constant features; fix pyright. #1205

merged 2 commits into from
Jul 30, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jul 26, 2024

Fixes #1204

@janfb janfb added the bug Something isn't working label Jul 26, 2024
@janfb janfb self-assigned this Jul 26, 2024
@janfb janfb requested a review from Baschdl July 26, 2024 15:03
@janfb janfb force-pushed the fix-c2st branch 3 times, most recently from d3b4b41 to f059ca3 Compare July 26, 2024 16:07
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.60%. Comparing base (ba19688) to head (983dfea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   84.55%   75.60%   -8.95%     
==========================================
  Files          96       96              
  Lines        7603     7630      +27     
==========================================
- Hits         6429     5769     -660     
- Misses       1174     1861     +687     
Flag Coverage Δ
unittests 75.60% <95.00%> (-8.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sbi/diagnostics/lc2st.py 95.95% <100.00%> (-0.08%) ⬇️
sbi/diagnostics/tarp.py 54.94% <100.00%> (-23.08%) ⬇️
sbi/inference/snle/snle_base.py 93.87% <100.00%> (+0.06%) ⬆️
sbi/inference/snpe/snpe_base.py 91.01% <100.00%> (+0.05%) ⬆️
sbi/inference/snre/snre_base.py 94.49% <100.00%> (+0.05%) ⬆️
sbi/samplers/vi/vi_divergence_optimizers.py 80.26% <100.00%> (-6.61%) ⬇️
sbi/utils/metrics.py 39.30% <100.00%> (-54.62%) ⬇️
sbi/utils/restriction_estimator.py 78.08% <100.00%> (-7.52%) ⬇️
sbi/utils/sbiutils.py 78.43% <100.00%> (-8.13%) ⬇️
sbi/analysis/plot.py 66.15% <0.00%> (ø)
... and 1 more

... and 20 files with indirect coverage changes

@janfb janfb changed the title fix #1204: c2st with constant features; refactoring. fix #1204: c2st with constant features; fix pyright. Jul 29, 2024
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! Small comment below.

sbi/utils/metrics.py Outdated Show resolved Hide resolved
@janfb janfb merged commit 923fb40 into main Jul 30, 2024
4 checks passed
@janfb janfb deleted the fix-c2st branch July 30, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c2st fails when one feature is constant
2 participants