Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup for process_x in EnsemblePosterior #1148

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fixup for process_x in EnsemblePosterior #1148

merged 1 commit into from
Apr 23, 2024

Conversation

michaeldeistler
Copy link
Contributor

@michaeldeistler michaeldeistler commented Apr 23, 2024

See @janfb's comment in #1138

we don't need the allow_iid check anymore?

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.03%. Comparing base (f0aa0f9) to head (01ede16).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   85.09%   77.03%   -8.07%     
==========================================
  Files          90       90              
  Lines        6649     6649              
==========================================
- Hits         5658     5122     -536     
- Misses        991     1527     +536     
Flag Coverage Δ
unittests 77.03% <0.00%> (-8.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sbi/inference/posteriors/ensemble_posterior.py 53.53% <0.00%> (-33.34%) ⬇️

... and 22 files with indirect coverage changes

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janfb janfb merged commit 005aeac into main Apr 23, 2024
4 of 5 checks passed
@michaeldeistler michaeldeistler deleted the fixup branch April 23, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants