Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt MNLE to new DensityEstimator abstraction #968

Closed
janfb opened this issue Feb 29, 2024 · 0 comments · Fixed by #1089
Closed

Adapt MNLE to new DensityEstimator abstraction #968

janfb opened this issue Feb 29, 2024 · 0 comments · Fixed by #1089
Assignees
Labels
architecture Internal changes without API consequences hackathon

Comments

@janfb
Copy link
Contributor

janfb commented Feb 29, 2024

Problem

MNLE is a variant of NLE, tailored to cases where x is discrete and continuous. It has its down density estimator, MixedDensityEstimator living here:

https://github.com/sbi-dev/sbi/blob/main/sbi/neural_nets/mnle.py

It would be nice to add MNLE to the new DensityEstimator abstraction, see #966 and #957. Otherwise we would need to handle it differently in the Posterior classes.

Solution

Let MixedDensityEstimator inherit from DensityEstimator and maybe move it to the designated module. The CategoricalNet is also a density (or rather mass) estimator. So it should be treated similarly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Internal changes without API consequences hackathon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants