Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimator abstractions #966

Closed
manuelgloeckler opened this issue Feb 28, 2024 · 0 comments · Fixed by #1151
Closed

Estimator abstractions #966

manuelgloeckler opened this issue Feb 28, 2024 · 0 comments · Fixed by #1151
Assignees
Labels
enhancement New feature or request hackathon

Comments

@manuelgloeckler
Copy link
Contributor

We currently only have the DensityEstimator abstraction, but we might want to expand this for other approaches. I would suggest something like this:

class Estimator(nn.Module):
    def loss(...)

class DensityEstimator(Estimator)
    def sample(...)
    def log_prob(...)
    def sample_and_log_prob(...)

class RatioEstimator(Estimator)
    def log_ratio(...)    ( Not sure, depends on what we need, here)

class ScoreEstimator(Estimator)
    def score(...)

The different Posterior Classes will implement the sample and log_prob methods anyway and must be adapted to support different estimators internally (if possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hackathon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants