Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RDS instance resource #90

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

kolsean
Copy link
Contributor

@kolsean kolsean commented Jul 28, 2021

This PR imports fixed sbercloud_rds_instance resource.
It fixes an issue when the instance cannot be created with empty database port value.
Related to huaweicloud/terraform-provider-huaweicloud#1204

All RDS-related acceptance tests are done well:

make testacc TEST='./sbercloud' TESTARGS='-run TestAccRds'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./sbercloud -v -run TestAccRds -timeout 360m -parallel=4
=== RUN   TestAccRdsFlavorV3DataSource_basic
=== PAUSE TestAccRdsFlavorV3DataSource_basic
=== RUN   TestAccRdsConfigurationV3_basic
=== PAUSE TestAccRdsConfigurationV3_basic
=== RUN   TestAccRdsInstanceV3_basic
=== PAUSE TestAccRdsInstanceV3_basic
=== RUN   TestAccRdsInstanceV3_withEpsId
=== PAUSE TestAccRdsInstanceV3_withEpsId
=== RUN   TestAccRdsInstanceV3_ha
=== PAUSE TestAccRdsInstanceV3_ha
=== RUN   TestAccRdsReadReplicaInstance_basic
=== PAUSE TestAccRdsReadReplicaInstance_basic
=== RUN   TestAccRdsReadReplicaInstance_withEpsId
=== PAUSE TestAccRdsReadReplicaInstance_withEpsId
=== CONT  TestAccRdsReadReplicaInstance_basic
=== CONT  TestAccRdsInstanceV3_ha
=== CONT  TestAccRdsFlavorV3DataSource_basic
=== CONT  TestAccRdsReadReplicaInstance_withEpsId
--- PASS: TestAccRdsFlavorV3DataSource_basic (10.48s)
=== CONT  TestAccRdsInstanceV3_basic
--- PASS: TestAccRdsInstanceV3_ha (612.12s)
=== CONT  TestAccRdsInstanceV3_withEpsId
--- PASS: TestAccRdsInstanceV3_basic (1079.58s)
=== CONT  TestAccRdsConfigurationV3_basic
--- PASS: TestAccRdsConfigurationV3_basic (16.82s)
--- PASS: TestAccRdsReadReplicaInstance_withEpsId (1119.19s)
--- PASS: TestAccRdsInstanceV3_withEpsId (608.43s)
--- PASS: TestAccRdsReadReplicaInstance_basic (1378.27s)
PASS
ok      github.com/sbercloud-terraform/terraform-provider-sbercloud/sbercloud   1378.656s

@niuzhenguo niuzhenguo merged commit d7923fb into sbercloud-terraform:master Jul 29, 2021
@kolsean kolsean deleted the fix-rds-port-issue branch February 7, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants