Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #385 #386

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Fix issue #385 #386

merged 3 commits into from
Oct 9, 2024

Conversation

bmbferreira
Copy link
Contributor

@bmbferreira bmbferreira commented Oct 1, 2024 •
edited
Loading

Adds missing check for TransactionStmtKind::Start when verifying the existence of transactions as this is the same as using BEGIN: https://www.postgresql.org/docs/current/sql-begin.html

Fixes #385

@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

👷 Deploy request for squawkhq pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3aa5e80

@bmbferreira bmbferreira changed the title Fixes #385 Fix https://github.com/sbdchd/squawk/issues/385 Oct 1, 2024
@bmbferreira bmbferreira changed the title Fix https://github.com/sbdchd/squawk/issues/385 Fix issue [#385](https://github.com/sbdchd/squawk/issues/385) Oct 1, 2024
@bmbferreira bmbferreira changed the title Fix issue [#385](https://github.com/sbdchd/squawk/issues/385) Fix issue #385 Oct 1, 2024
@bmbferreira bmbferreira closed this Oct 2, 2024
@bmbferreira bmbferreira reopened this Oct 2, 2024
@bmbferreira bmbferreira closed this Oct 2, 2024
@bmbferreira bmbferreira reopened this Oct 2, 2024
chdsbd
chdsbd approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@chdsbd chdsbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chdsbd chdsbd added the automerge automerge with kodiak label Oct 9, 2024
@kodiakhq kodiakhq bot merged commit 12aa7b6 into sbdchd:master Oct 9, 2024
62 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chdsbd chdsbd chdsbd approved these changes

Assignees
No one assigned
Labels
automerge automerge with kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive for prefer-robust-stmts being reported even inside a transaction
2 participants
@bmbferreira @chdsbd