Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix urlpatterns use Sequence instead of List #19

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix urlpatterns use Sequence instead of List #19

merged 1 commit into from
Apr 12, 2022

Conversation

kylebebak
Copy link

Use Sequence instead of List in apply_suffix_patterns and format_suffix_patterns. This thread, python/mypy#3351 (comment), explains why List, which is invariant, isn't suitable here

@kodiakhq kodiakhq bot merged commit d17362e into sbdchd:master Apr 12, 2022
@sbdchd
Copy link
Owner

sbdchd commented Apr 12, 2022

Thank you!!

@kylebebak
Copy link
Author

Thank you!

@kylebebak kylebebak deleted the fix_urlpatterns_use_sequence_instead_of_list branch April 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebebak @sbdchd