forked from typeddjango/django-stubs
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve django.http
types
#208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change was made to CaseInsensitiveMapping in previous commit.
mypy doesn't like how the return types changed in HttpResponse.
noelleleigh
force-pushed
the
improve-http
branch
from
October 31, 2023 17:15
686c257
to
8500198
Compare
sbdchd
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds polish to several classes in the
django.http
module:django.http.request.HttpHeaders
django.http.request.HttpRequest
django.http.response.ResponseHeaders
django.http.response.HttpResponse
django.http.response.StreamingHttpResponse
django.http.response.FileResponse
django.utils.datastructures.CaseInsensitiveMapping
The changes broadly fall under:
Any
with specific types, remove= ...
for class attributes that are always defined, usetyping.Never
for methods and properties that always raise an exception)Some of the changes here could definitely be interpreted as stylistic rather than functional, and I'll happily make any changes that are requested.