Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify config files #188

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Unify config files #188

merged 1 commit into from
Sep 2, 2023

Conversation

hamdanal
Copy link

@hamdanal hamdanal commented Sep 2, 2023

flake8 configuration was scattered over .flake8 and tox.ini; pytest configuration was also scattered over pytest.ini and tox.ini. The problem is one file will take precedence and the configuration from the other will be either ignored or merged depending on the tool. This PR unifies the configuration of flake8 in .flake8 and of pytest in pyproject.toml and deletes tox.ini because tox is not used by the project.

@@ -1,4 +1,41 @@
[flake8]
extend-ignore = Y015
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now part of the ignore list

@sbdchd
Copy link
Owner

sbdchd commented Sep 2, 2023

Thanks!

@kodiakhq kodiakhq bot merged commit ae7e7ab into sbdchd:main Sep 2, 2023
@hamdanal hamdanal deleted the toxless branch September 2, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants