Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remaining ruff rules #187

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Enable remaining ruff rules #187

merged 2 commits into from
Sep 2, 2023

Conversation

hamdanal
Copy link

@hamdanal hamdanal commented Sep 2, 2023

This is the last PR of a series of PRs updating the project syntax using ruff (continuation of #185).

In this PR I activate the remaining two rules:

  1. other parameter to __eq__ method should always be annotated as object
  2. Quoting forward references (stringifing types) is unnecessary in stubs

This PR is fairly small compared to the previous ones

@sbdchd
Copy link
Owner

sbdchd commented Sep 2, 2023

Thank you!

@kodiakhq kodiakhq bot merged commit d1c8fca into sbdchd:main Sep 2, 2023
@hamdanal hamdanal deleted the ruff-all branch September 2, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants