Use PEP-585 standard generic collections #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran ruff with "UP006" rule autofixes for PEP-585 upgrades and some other relevant rules. Ruff runs now as part of the linters to make sure that the library stays up-to-date. When running `./s/lint` locally, it autofixes the errors inplace. When run in CI, it just prints them to the terminal. This is similar to how black and isort are invoked.
|
As discussed in #183 (comment). The commented out ruff rules in pyproject.toml will be activated in following PRs, otherwise it will be very difficult to review all the changes. |
sbdchd
reviewed
Aug 27, 2023
| @@ -189,7 +192,7 @@ STATIC_ROOT: Optional[str] = ... | |||
| STATIC_URL: Optional[str] = ... | |||
There was a problem hiding this comment.
surprised it didn't update Optional[str] to str | None
There was a problem hiding this comment.
Yeah this will be updated in the next PR I prepared to use PEP-604 (A | B and A | None) syntax. The changes are huge I had to split them to multiple PRs.
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 27, 2023
Activate the ruff lint rule "UP007" that updates `typing.Union` and `typing.Optional` to use the ` | ` syntax. I also made some manual fixups for the cases that were not updated by ruff. This is a continuation of #184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran ruff with "UP006" rule autofixes for PEP-585 upgrades and some other relevant rules.
Ruff runs now as part of the linters to make sure that the library stays up-to-date. When running
./s/lintlocally, it autofixes the errors inplace. When run in CI, it just prints them to the terminal. This is similar to how black and isort are invoked.