Skip to content

Commit

Permalink
Fix for offline upgrade missing download_script_subdir var (hitachien…
Browse files Browse the repository at this point in the history
plirglo authored Nov 26, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 8b3766b commit 33ff19a
Showing 3 changed files with 14 additions and 7 deletions.
14 changes: 7 additions & 7 deletions ansible/playbooks/roles/repository/tasks/setup.yml
Original file line number Diff line number Diff line change
@@ -9,15 +9,15 @@
debug:
var: offline_mode

- name: Set directory name for download script
set_fact:
download_script_subdir: >-
{{ 'centos-7' if (ansible_distribution == 'CentOS' and ansible_distribution_major_version == '7') else
'redhat-7' if (ansible_distribution == 'RedHat' and ansible_distribution_major_version == '7') else
'ubuntu-18.04' if (ansible_distribution == 'Ubuntu' and ansible_distribution_version == '18.04') else None }}
- name: Download Epiphany requirements on repository host # online mode
block:
- name: Set directory name for download script
set_fact:
download_script_subdir: >-
{{ 'centos-7' if (ansible_distribution == 'CentOS' and ansible_distribution_major_version == '7') else
'redhat-7' if (ansible_distribution == 'RedHat' and ansible_distribution_major_version == '7') else
'ubuntu-18.04' if (ansible_distribution == 'Ubuntu' and ansible_distribution_version == '18.04') else None }}
- name: Check if OS distribution is supported
assert:
that: download_script_subdir | length > 0
1 change: 1 addition & 0 deletions docs/changelogs/CHANGELOG-1.3.md
Original file line number Diff line number Diff line change
@@ -24,6 +24,7 @@
- [#1587](https://github.com/epiphany-platform/epiphany/issues/1587) - Duplicated SANs for K8s apiserver certificate
- [#1661](https://github.com/epiphany-platform/epiphany/issues/1661) - Changing the default Kubernetes certificate location results in a cluster deployment error
- [#2707](https://github.com/epiphany-platform/epiphany/issues/2707) - Fix logging component backup
- [#2753](https://github.com/epiphany-platform/epiphany/issues/2753) - Failing offline upgrade: 'download_script_subdir' is undefined

### Updated

6 changes: 6 additions & 0 deletions docs/home/howto/UPGRADE.md
Original file line number Diff line number Diff line change
@@ -146,6 +146,12 @@ The `epicli upgrade` command has additional flags:
epicli upgrade -b /buildoutput/ --upgrade-components "kafka,filebeat"
```

**NOTE**

Parameter `--upgrade-components` should be use only for develop or testing purposes. Do not use this option for production enviroments, since it may generate additional errors when running `apply` after that kind of upgrade

---

## Run *apply* after *upgrade*

Currently, Epiphany does not fully support apply after upgrade. There is a possibility to re-apply configuration from

0 comments on commit 33ff19a

Please sign in to comment.