Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(journey-maps): upgrade maplibre to 4.7.1 #2421

Merged
merged 5 commits into from
Nov 7, 2024
Merged

chore(journey-maps): upgrade maplibre to 4.7.1 #2421

merged 5 commits into from
Nov 7, 2024

Conversation

swiss-chris
Copy link
Contributor

Refs: ROKAS-2089

@mstankala
Copy link
Contributor

mstankala commented Nov 7, 2024 •
edited
Loading

https://github.com/search?q=repo%3Asbb-design-systems%2Fsbb-angular%20%223.6%22&type=code
[/src/journey-maps/package.json]
[/src/showcase/assets/stack-blitz/package.json]
still with old version

mstankala
mstankala approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@mstankala mstankala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swiss-chris swiss-chris changed the title docs(journey-maps): upgrade maplibre to 4.7.1 chore(journey-maps): upgrade maplibre to 4.7.1 Nov 7, 2024
mhaertwig
mhaertwig reviewed Nov 7, 2024
View reviewed changes
src/showcase/app/shared/shared.module.ts
SbbSidebarModule,
SbbAccordionModule,
RouterModule,
CommonModule,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @swiss-chris

@mhaertwig mhaertwig merged commit cc141ae into main Nov 7, 2024
20 checks passed
@mhaertwig mhaertwig deleted the feature/cdi/ROKAS-2089-upgrade-maplibre branch November 7, 2024 14:36
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Open
3 tasks
mhaertwig pushed a commit that referenced this pull request Nov 7, 2024
@swiss-chris @mhaertwig
chore(journey-maps): upgrade maplibre to 4.7.1 (#2421)
39be004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstankala mstankala mstankala approved these changes

@mhaertwig mhaertwig mhaertwig approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

Assignees
No one assigned
Labels
target: 18.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swiss-chris @mstankala @mhaertwig