Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle scroll events in custom scroll contexts #3310

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jeripeierSBB
Copy link
Contributor

Closes #3276

@github-actions github-actions bot added target: 2.x pr: peer review required A peer review is required for this pull request labels Dec 18, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/elements/menu/menu/menu.ts Show resolved Hide resolved
src/elements/popover/popover/popover.ts Show resolved Hide resolved
src/elements/select/select.ts Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Dec 18, 2024
@github-actions github-actions bot temporarily deployed to pr3310 December 18, 2024 10:35 Inactive
@github-actions github-actions bot temporarily deployed to pr3310-diff December 18, 2024 10:36 Inactive
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Dec 18, 2024
@github-actions github-actions bot temporarily deployed to pr3310 December 18, 2024 11:27 Inactive
@github-actions github-actions bot temporarily deployed to pr3310-diff December 18, 2024 11:27 Inactive
@github-actions github-actions bot temporarily deployed to pr3310 December 18, 2024 13:35 Inactive
@github-actions github-actions bot temporarily deployed to pr3310-diff December 18, 2024 13:35 Inactive
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB jeripeierSBB merged commit b47ee15 into main Dec 19, 2024
18 of 19 checks passed
@jeripeierSBB jeripeierSBB deleted the shadow-scrolling branch December 19, 2024 13:21
kyubisation pushed a commit that referenced this pull request Dec 19, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.0.2](v2.0.1...v2.0.2)
(2024-12-19)


### Bug Fixes

* handle scroll events in custom scroll contexts
([#3310](#3310))
([3634e37](3634e37)),
closes
[#3276](#3276)
* improve null/undefined type handling for Angular wrapper
([#3302](#3302))
([2f94992](2f94992))
* remove any type for Angular wrapper
([#3297](#3297))
([dca7ba5](dca7ba5))
* remove leading inline padding from icon list
([#3311](#3311))
([b9ce6d1](b9ce6d1))
* **sbb-accent-button:** adapt to new design
([#3313](#3313))
([1af2691](1af2691))
* **sbb-message:** fix image alignment
([#3305](#3305))
([1d4a5de](1d4a5de))
* **sbb-select:** update displayed value on option label change
([#3300](#3300))
([3c2f3c5](3c2f3c5))
* **sbb-teaser-hero:** fix image size on custom width
([#3295](#3295))
([5fc0634](5fc0634))


### Documentation

* override member properties in manifest
([#3307](#3307))
([ba25320](ba25320))
* standardize usage of terms `CSS` and `Sass`
([#3290](#3290))
([b52ac99](b52ac99))


### Code Refactoring

* move event handlers to constructors
([#3314](#3314))
([18660a3](18660a3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available target: 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: autocomplete drop-down does not scroll with content in scrollable sbb-dialog
4 participants