-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbb-message): support the use of figure
as image
#3294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
target: 2.x
pr: peer review required
A peer review is required for this pull request
labels
Dec 12, 2024
jeripeierSBB
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
github-actions
bot
added
the
pr: lead review approved
Pull request has been approved by a lead review
label
Dec 12, 2024
TomMenga
changed the title
feat(sbb-message): support the use of
fix(sbb-message): support the use of Dec 12, 2024
figure
as imagefigure
as image
github-actions
bot
added
pr: peer review required
A peer review is required for this pull request
and removed
pr: peer review required
A peer review is required for this pull request
labels
Dec 12, 2024
jeripeierSBB
pushed a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.1](v2.0.0...v2.0.1) (2024-12-12) ### Features * add class generic type param in manifest ([#3292](#3292)) ([3d872c1](3d872c1)) ### Bug Fixes * **sbb-message:** support the use of `figure` as image ([#3294](#3294)) ([1d64853](1d64853)) * **sbb-radio-button-panel:** remove extension clause in mixin which cause incorrect manifest generation ([#3288](#3288)) ([b5457a7](b5457a7)) * **sbb-teaser:** fix image related issues ([#3293](#3293)) ([e6f517b](e6f517b)) ### Miscellaneous Chores * release 2.0.1 ([2a43d06](2a43d06)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: lead review approved
Pull request has been approved by a lead review
pr: peer review required
A peer review is required for this pull request
pr: visual review required
target: 2.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.