Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix type of globalThis #3259

Merged
merged 1 commit into from
Dec 2, 2024
Merged

build: fix type of globalThis #3259

merged 1 commit into from
Dec 2, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Nov 29, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Dec 2, 2024
@jeripeierSBB jeripeierSBB merged commit e8d88b1 into main Dec 2, 2024
30 checks passed
@jeripeierSBB jeripeierSBB deleted the globalThis-type branch December 2, 2024 08:38
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
1 task
jeripeierSBB added a commit that referenced this pull request Dec 2, 2024
(cherry picked from commit e8d88b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available target: 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants