Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): introduce table size xs #3077

Merged
merged 4 commits into from
Sep 12, 2024
Merged

feat(table): introduce table size xs #3077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6f78c6
feat(table): introduce table style xs
mcilurzo Sep 11, 2024
b1b047b
test(table): add visual spec for size 'xs'
TomMenga Sep 11, 2024
2d2c9da
feat(table): add visual regression test
mcilurzo Sep 11, 2024
a6eaef1
Merge branch 'feat/table/introduce-size-xs' of https://github.com/sbb…
mcilurzo Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/elements/core/styles/mixins/table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,17 @@
}
}

@mixin table--xs {
--sbb-table-header-padding-block: 0;
--sbb-table-header-padding-inline: var(--sbb-spacing-fixed-1x);
--sbb-table-cell-padding-block: 0;
--sbb-table-cell-padding-inline: var(--sbb-spacing-fixed-1x);

tbody > tr > td {
@include typo.text-xs--regular;
}
}

@mixin table--theme-iron {
--sbb-table-cell-color: var(--sbb-color-iron);

Expand Down
7 changes: 6 additions & 1 deletion src/elements/core/styles/table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

.sbb-table,
.sbb-table-m,
.sbb-table-s {
.sbb-table-s,
.sbb-table-xs {
@include table.table;
}

Expand All @@ -14,6 +15,10 @@
@include table.table--s;
}

.sbb-table-xs {
@include table.table--xs;
}

sbb-table-wrapper[negative] .sbb-table,
.sbb-table--negative {
@include table.table--negative;
Expand Down
9 changes: 8 additions & 1 deletion src/storybook/styles/table/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ By default, tables are styled with alternating row stripes to enhance readabilit

### Size

The available sizes are `m` (default) and `s`. Use the respective `sbb-table-*size*` classes to specify it:
The available sizes are `m` (default), `s` and `xs`. Use the respective `sbb-table-*size*` classes to specify it:

```html
<table class="sbb-table-s">
Expand All @@ -48,6 +48,12 @@ The available sizes are `m` (default) and `s`. Use the respective `sbb-table-*si
<table class="sbb-table-m">
...
</table>

<!-- Or -->

<table class="sbb-table-xs">
...
</table>
```

### Negative variant
Expand Down Expand Up @@ -81,6 +87,7 @@ Therefore, we provide mixins you can build on top of:
| `table` | `sbb-table` | The table style (equivalent to `table-m`) |
| `table--m` | `sbb-table-m` | Medium size table style |
| `table--s` | `sbb-table-s` | Small size table style |
| `table--xs` | `sbb-table-xs` | Smallest size table style |
| `table--negative` | `sbb-table--negative` | Negative variant style |
| `table--striped` | `sbb-table--striped` | Striped table style |
| `table--unstriped` | `sbb-table--unstriped` | Non-striped table style |
Expand Down
9 changes: 8 additions & 1 deletion src/storybook/styles/table/table.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const size: InputType = {
control: {
type: 'inline-radio',
},
options: ['s', 'm'],
options: ['xs', 's', 'm'],
};

const negative: InputType = {
Expand Down Expand Up @@ -91,6 +91,7 @@ const Template = (args: Args): TemplateResult => html`
<table
class=${classMap({
'sbb-table--negative': args.negative,
'sbb-table-xs': args.size === 'xs',
TomMenga marked this conversation as resolved.
Show resolved Hide resolved
'sbb-table-s': args.size === 's',
'sbb-table-m': args.size === 'm',
'sbb-table--unstriped': !args.striped,
Expand All @@ -113,6 +114,12 @@ export const SizeS: StoryObj = {
args: { ...defaultArgs, size: 's' },
};

export const SizeXS: StoryObj = {
render: Template,
argTypes: defaultArgTypes,
args: { ...defaultArgs, size: 'xs' },
};

export const Negative: StoryObj = {
render: Template,
argTypes: defaultArgTypes,
Expand Down
3 changes: 2 additions & 1 deletion src/storybook/styles/table/table.visual.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe(`table`, () => {
};

const sizeCases = {
size: ['m', 's'],
size: ['m', 's', 'xs'],
};

const tableTemplate = (classInfo: ClassInfo): TemplateResult => html`
Expand Down Expand Up @@ -78,6 +78,7 @@ describe(`table`, () => {
visualDiffDefault.with(async (setup) => {
await setup.withFixture(
tableTemplate({
'sbb-table-xs': size === 'xs',
'sbb-table-s': size === 's',
'sbb-table-m': size === 'm',
}),
Expand Down
Loading