Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-sticky-bar): fade in vertically during initial load #3073

Merged
merged 16 commits into from
Nov 20, 2024
Merged

feat(sbb-sticky-bar): fade in vertically during initial load #3073

merged 16 commits into from
Nov 20, 2024

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Sep 10, 2024 •
edited
Loading

Closes #3072

BEGIN_COMMIT_OVERRIDE
feat(sbb-sticky-bar): introduce controllable slide in and out animation

Closes #3072
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Sep 10, 2024
@github-actions github-actions bot temporarily deployed to pr3073 September 10, 2024 13:15 Inactive
@github-actions github-actions bot temporarily deployed to pr3073-diff September 10, 2024 13:15 Inactive
MarioCastigliano
MarioCastigliano approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few considerations, but overall a solid job 👍

src/elements/container/sticky-bar/sticky-bar.ts Outdated Show resolved Hide resolved
src/elements/container/sticky-bar/sticky-bar.ts Outdated Show resolved Hide resolved
src/elements/container/sticky-bar/sticky-bar.ts Show resolved Hide resolved
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Sep 11, 2024
@jeripeierSBB jeripeierSBB linked an issue Sep 16, 2024 that may be closed by this pull request
[Feature request]: StickyBar animation FadeIn and FadeOut #3078
Closed
3 tasks
@jeripeierSBB jeripeierSBB changed the title feat(sbb-sticky-bar): fade in vertically during initial load feat(sbb-sticky-bar): fade in vertically during initial load [WIP] Sep 18, 2024
@jeripeierSBB
Merge remote-tracking branch 'origin/feat-sticky-bar' into feat-stick…
c743549 
…y-bar
@jeripeierSBB
Merge branch 'main' into feat-sticky-bar
3ef5e05 
# Conflicts:
#	src/elements/container/sticky-bar/readme.md
#	src/elements/container/sticky-bar/sticky-bar.ts
@github-actions github-actions bot temporarily deployed to pr3073 November 13, 2024 16:13 Inactive
@github-actions github-actions bot temporarily deployed to pr3073 November 14, 2024 16:36 Inactive
@github-actions github-actions bot temporarily deployed to pr3073-diff November 14, 2024 16:37 Inactive
@jeripeierSBB jeripeierSBB changed the title feat(sbb-sticky-bar): fade in vertically during initial load [WIP] feat(sbb-sticky-bar): fade in vertically during initial load Nov 14, 2024
@jeripeierSBB jeripeierSBB added the pr: ux review required A ux review is required for this pull request label Nov 18, 2024
kyubisation
kyubisation approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeripeierSBB
Merge branch 'main' into feat-sticky-bar
a35d042 
# Conflicts:
#	src/elements/core/testing/event-spy.ts
@mcilurzo mcilurzo added ux approved Issue is approved by UX and removed pr: ux review required A ux review is required for this pull request labels Nov 20, 2024
@jeripeierSBB jeripeierSBB added pr: ux review approved Pull request has been approved by a ux review and removed ux approved Issue is approved by UX labels Nov 20, 2024
@jeripeierSBB jeripeierSBB merged commit 11884da into main Nov 20, 2024
25 of 26 checks passed
@jeripeierSBB jeripeierSBB deleted the feat-sticky-bar branch November 20, 2024 09:11
sbb-design-systems-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@jeripeierSBB
feat(sbb-sticky-bar): introduce controllable slide and out animation (#…
ea04e08 
…3073)

This change allows controlling the position: sticky property and also handles slide in on initial load.

Closes #3072
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

Assignees
No one assigned
Labels
diff-available pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available target: 1.x
Projects
None yet
Milestone
No milestone
4 participants
@jeripeierSBB @kyubisation @MarioCastigliano @mcilurzo