Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: stabilize image loading for visual regression tests #3023

Merged
merged 20 commits into from
Aug 28, 2024
Merged

build: stabilize image loading for visual regression tests #3023

merged 20 commits into from
Aug 28, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Aug 26, 2024
@github-actions github-actions bot temporarily deployed to pr3023 August 26, 2024 07:18 Inactive
@github-actions github-actions bot temporarily deployed to pr3023-diff August 26, 2024 07:18 Inactive
@github-actions github-actions bot temporarily deployed to pr3023 August 26, 2024 07:45 Inactive
@github-actions github-actions bot temporarily deployed to pr3023-diff August 26, 2024 07:46 Inactive
@github-actions github-actions bot temporarily deployed to pr3023 August 26, 2024 08:47 Inactive
@github-actions github-actions bot temporarily deployed to pr3023-diff August 26, 2024 08:47 Inactive
@github-actions github-actions bot temporarily deployed to pr3023 August 26, 2024 09:17 Inactive
@github-actions github-actions bot temporarily deployed to pr3023-diff August 26, 2024 09:18 Inactive
@github-actions github-actions bot temporarily deployed to pr3023 August 27, 2024 13:25 Inactive
@github-actions github-actions bot temporarily deployed to pr3023-diff August 27, 2024 13:25 Inactive
@github-actions github-actions bot temporarily deployed to pr3023 August 28, 2024 06:07 Inactive
@github-actions github-actions bot temporarily deployed to pr3023-diff August 28, 2024 06:08 Inactive
kyubisation
kyubisation approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/elements/core/testing/wait-for-image-ready.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Aug 28, 2024
@jeripeierSBB jeripeierSBB merged commit 6000abc into main Aug 28, 2024
14 of 16 checks passed
@jeripeierSBB jeripeierSBB deleted the stabilize-visual-regression branch August 28, 2024 10:35
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeripeierSBB @kyubisation