-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-flip-card): first implementation #2946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding the two suggestions should solve the height issue.
The animation for this might not be perfect yet, but apparently there is still a discussion ongoing on how this should look anyway.
Animation does not yet meet the requirements: Compared to the specification for the animation (https://www.figma.com/design/9r6xSfNmEfCFxl1yFYedrj/Lyne-Components?node-id=39138-765544&t=iU5yxm8WRYiYnQdz-4), there are still various deviations. Please ensure the following: Duration: Please ensure that duration and easing correspond to the specifications. Title: The opacity of the title should fade to 0% when the card is clicked. So that the content and title do not overlap visually. |
Button size S instead of L |
Minimum height and above all independent of the content of the open state. Zero-Micro:
Small:
Medium-Large:
Wide-Ultra:
|
@florianstuerzinger Just a heads-up; The animation will not be perfect yet, but we will continue working on it and can fix that at a later date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks again! 😃
Preflight Checklist
Issue
This PR Closes #2669
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
sbb-flip-card
has been implementedsbb-flip-card-summary
has been implementedsbb-flip-card-details
has been implementedBrowsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information