Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-radio-button, sbb-radio-button-group): add size xs #2936

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Jul 15, 2024

Preflight Checklist

Issue

This PR Closes #2766

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • sbb-radio-button, sbb-radio-button-group: add size xs

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 15, 2024
@TomMenga TomMenga added the pr: ux review required A ux review is required for this pull request label Jul 15, 2024
@github-actions github-actions bot temporarily deployed to pr2936 July 15, 2024 08:37 Inactive
@github-actions github-actions bot temporarily deployed to pr2936-diff July 15, 2024 08:38 Inactive
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
the panel needs the size's explanation paragraph in the readme

Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous review was wrongly published

Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jul 16, 2024
@TomMenga TomMenga merged commit 7237dce into main Jul 16, 2024
19 of 20 checks passed
@TomMenga TomMenga deleted the feat/radiobutton-size-xs branch July 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: peer review approved Pull request has been approved by a peer review pr: ux review required A ux review is required for this pull request pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radiobutton: Size XS
2 participants