Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-checkbox): add size xs #2933

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Jul 12, 2024

Preflight Checklist

Issue

This PR Closes #2767

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • the size property in the sbb-chechbox has now a new value named xs
  • the sbb-visual-checkbox has now a size property with the same values of the sbb-checkbox's size

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot temporarily deployed to pr2933 July 12, 2024 09:01 Inactive
@github-actions github-actions bot temporarily deployed to pr2933-diff July 12, 2024 09:02 Inactive
@DavideMininni-Fincons DavideMininni-Fincons linked an issue Jul 12, 2024 that may be closed by this pull request
@github-actions github-actions bot requested a deployment to pr2933 July 12, 2024 14:10 In progress
@github-actions github-actions bot requested a deployment to pr2933-diff July 12, 2024 14:10 In progress
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat(sbb-checkbox): add size xs [WIP] feat(sbb-checkbox): add size xs Jul 12, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 12, 2024
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😄
Some minor fixes

src/elements/checkbox/checkbox-panel/checkbox-panel.ts Outdated Show resolved Hide resolved
src/elements/checkbox/checkbox-panel/checkbox-panel.ts Outdated Show resolved Hide resolved
src/elements/checkbox/checkbox/checkbox.ts Outdated Show resolved Hide resolved
src/elements/checkbox/checkbox/readme.md Outdated Show resolved Hide resolved
src/elements/visual-checkbox/readme.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss-clicked the previous review and published it as "comments" :|

@github-actions github-actions bot temporarily deployed to pr2933 July 15, 2024 15:38 Inactive
@github-actions github-actions bot temporarily deployed to pr2933-diff July 15, 2024 15:39 Inactive
@github-actions github-actions bot temporarily deployed to pr2933 July 16, 2024 07:57 Inactive
@github-actions github-actions bot temporarily deployed to pr2933-diff July 16, 2024 07:58 Inactive
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jul 16, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 56db302 into main Jul 16, 2024
19 of 20 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/sbb-checkbox-size-xs branch July 16, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox: Size XS
2 participants