Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-tag): add visual tests #2898

Merged
merged 4 commits into from
Jul 8, 2024
Merged

test(sbb-tag): add visual tests #2898

merged 4 commits into from
Jul 8, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

No description provided.

@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Jul 5, 2024
Closed
71 tasks
@github-actions github-actions bot temporarily deployed to pr2898 July 5, 2024 13:47 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title test(sbb-tag): add visual tests [WIP] test(sbb-tag): add visual tests Jul 8, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 8, 2024
TomMenga
TomMenga approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Maybe just an improvement

src/elements/tag/tag-group/tag-group.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jul 8, 2024
jeripeierSBB
jeripeierSBB approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/elements/tag/tag-group/tag-group.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 8, 2024
@github-actions github-actions bot temporarily deployed to pr2898 July 8, 2024 10:47 Inactive
@DavideMininni-Fincons DavideMininni-Fincons merged commit a8b26ff into main Jul 8, 2024
15 of 16 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-tag branch July 8, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@TomMenga TomMenga TomMenga approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavideMininni-Fincons @TomMenga @jeripeierSBB