-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(sbb-selection-expansion-panel): add visual spec #2895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, maybe I would try to optimize the number of screenshots since for all the cases where the panel is closed the visual tests on the radio-button/checkbox would practically overlap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically looks good. One thought:
Comparing https://lyne-components-visual-regression-diff-pr2895.app.sbb.ch/compare/sbb-selection-expansion-panel/checkbox_group_with_error to https://lyne-components-visual-regression-diff-pr2895.app.sbb.ch/compare/sbb-selection-expansion-panel/radio_button_group_with_error has a shift between the price. is this only an example problem or do we have style problems in the component itself?
I was already investigating it and I'd say it's a component problem. This is due to the different "dom structure" between the radio and the checkbox. |
No description provided.