Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove .keep file #2892

Merged
merged 1 commit into from
Jul 4, 2024
Merged

build: remove .keep file #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/continuous-integration-secure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,6 @@ jobs:
run-id: ${{ github.event.workflow_run.id }}
github-token: ${{ secrets.GH_ACTIONS_ARTIFACT_DOWNLOAD }}

# TODO: Remove once meta file workflow has elaborated
- name: Remove .keep file
run: rm dist/screenshots/.keep || true

- name: Build visual-regression-app
run: yarn build:visual-regression-app

Expand Down
4 changes: 0 additions & 4 deletions tools/visual-regression-testing/prepare-failed-screenshots-artifact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { writeFileSync } from 'fs';
import { type CopySyncOptions, cpSync, existsSync, mkdirSync } from 'node:fs';

import * as glob from 'glob';
Expand All @@ -14,9 +13,6 @@ const artifactDir = new URL('../../dist/screenshots-artifact/', import.meta.url)
const copyOptions: CopySyncOptions = { force: true, recursive: true };
mkdirSync(artifactDir, { recursive: true });

// TODO: remove once on main
writeFileSync(new URL('./.keep', artifactDir), '', 'utf8');

cpSync(new URL('./meta.json', screenshotDir), new URL('./meta.json', artifactDir), copyOptions);

const failedDirs = glob.sync('*/failed/', { cwd: screenshotDir });
Expand Down
Loading