Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(skiplink-list): add visual spec #2888

Merged
merged 3 commits into from
Jul 8, 2024
Merged

test(skiplink-list): add visual spec #2888

merged 3 commits into from
Jul 8, 2024

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Jul 4, 2024

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 4, 2024
@github-actions github-actions bot temporarily deployed to pr2888 July 4, 2024 08:33 Inactive
@TomMenga TomMenga mentioned this pull request Jul 4, 2024
Closed
71 tasks
DavideMininni-Fincons
DavideMininni-Fincons reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some comments added

src/elements/skiplink-list/skiplink-list.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/skiplink-list/skiplink-list.visual.spec.ts Outdated Show resolved Hide resolved
DavideMininni-Fincons
DavideMininni-Fincons approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jul 5, 2024
jeripeierSBB
jeripeierSBB approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 8, 2024
@TomMenga TomMenga merged commit eeb4160 into main Jul 8, 2024
23 of 24 checks passed
@TomMenga TomMenga deleted the visual-spec/skiplink-list branch July 8, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideMininni-Fincons DavideMininni-Fincons DavideMininni-Fincons approved these changes

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomMenga @jeripeierSBB @DavideMininni-Fincons