Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-overlay): add visual tests #2864

Merged
merged 8 commits into from
Jul 3, 2024
Merged

test(sbb-overlay): add visual tests #2864

merged 8 commits into from
Jul 3, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

No description provided.

@DavideMininni-Fincons DavideMininni-Fincons changed the title test(sbb-overlay: add visual tests [WIP] test(sbb-overlay): add visual tests [WIP] Jul 1, 2024
@github-actions github-actions bot temporarily deployed to pr2864 July 1, 2024 13:06 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title test(sbb-overlay): add visual tests [WIP] test(sbb-overlay): add visual tests Jul 1, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 1, 2024
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Jul 1, 2024
Closed
71 tasks
@github-actions github-actions bot temporarily deployed to pr2864 July 1, 2024 16:12 Inactive
jeripeierSBB
jeripeierSBB requested changes Jul 2, 2024
View reviewed changes
src/elements/overlay/overlay.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/overlay/overlay.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/overlay/overlay.visual.spec.ts Show resolved Hide resolved
src/elements/overlay/overlay.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/overlay/overlay.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/overlay/overlay.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/overlay/overlay.visual.spec.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2864 July 2, 2024 09:12 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably one redundant line

src/elements/overlay/overlay.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 3, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 9789891 into main Jul 3, 2024
20 of 22 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-overlay branch July 3, 2024 08:56
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jul 3, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@TomMenga TomMenga Awaiting requested review from TomMenga

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavideMininni-Fincons @kyubisation @jeripeierSBB