Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace isolated SbbSlotStateController usage with decorator #2856

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

kyubisation
Copy link
Contributor

@kyubisation kyubisation commented Jun 28, 2024

This PR replaces the constructor usage of SbbSlotStateController with the decorator slotChange, which applies the SbbSlotStateController internally.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 28, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 1, 2024
@kyubisation kyubisation merged commit fa91b76 into main Jul 1, 2024
29 of 31 checks passed
@kyubisation kyubisation deleted the refactor-slot-state branch July 1, 2024 14:46
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants