Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run playwright browsers in a container for visual regression testing #2821

Merged
merged 5 commits into from
Jun 25, 2024
Merged

build: run playwright browsers in a container for visual regression testing #2821

merged 5 commits into from
Jun 25, 2024

Conversation

kyubisation
Copy link
Contributor

No description provided.

@kyubisation kyubisation requested a review from TomMenga June 25, 2024 09:57
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 25, 2024
jeripeierSBB
jeripeierSBB approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 25, 2024
@kyubisation kyubisation merged commit ebded24 into main Jun 25, 2024
25 of 26 checks passed
@kyubisation kyubisation deleted the build-browser-container branch June 25, 2024 14:30
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@TomMenga TomMenga Awaiting requested review from TomMenga

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyubisation @jeripeierSBB