Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-file-selector): add visual tests #2812

Merged
merged 3 commits into from
Jun 25, 2024
Merged

test(sbb-file-selector): add visual tests #2812

merged 3 commits into from
Jun 25, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 24, 2024
@github-actions github-actions bot temporarily deployed to pr2812 June 24, 2024 10:40 Inactive
TomMenga
TomMenga requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gg
Some minor fixes

src/elements/file-selector/file-selector.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/file-selector/file-selector.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/file-selector/file-selector.visual.spec.ts Show resolved Hide resolved
src/elements/file-selector/file-selector.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/file-selector/file-selector.visual.spec.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2812 June 24, 2024 13:51 Inactive
TomMenga
TomMenga approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍
Just a nitpick

src/elements/file-selector/file-selector.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jun 25, 2024
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Jun 25, 2024
Closed
71 tasks
@DavideMininni-Fincons DavideMininni-Fincons merged commit 35384eb into main Jun 25, 2024
21 of 22 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-file-selector branch June 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMenga TomMenga TomMenga approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

Assignees
No one assigned
Labels
diff-available pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideMininni-Fincons @TomMenga