Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-container, sbb-sticky-bar): add visual spec #2798

Merged
merged 5 commits into from
Jun 26, 2024
Merged

test(sbb-container, sbb-sticky-bar): add visual spec #2798

merged 5 commits into from
Jun 26, 2024

Conversation

TomMenga
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 20, 2024
@github-actions github-actions bot temporarily deployed to pr2798 June 20, 2024 12:37 Inactive
@TomMenga TomMenga mentioned this pull request Jun 20, 2024
Closed
71 tasks
@github-actions github-actions bot temporarily deployed to pr2798 June 20, 2024 13:53 Inactive
jeripeierSBB
jeripeierSBB requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests. Some suggestions

src/elements/container/container/container.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/container/sticky-bar/sticky-bar.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/container/sticky-bar/sticky-bar.visual.spec.ts Show resolved Hide resolved
jeripeierSBB
jeripeierSBB approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 25, 2024
@TomMenga TomMenga merged commit 60577ff into main Jun 26, 2024
24 of 26 checks passed
@TomMenga TomMenga deleted the visual-spec/container branch June 26, 2024 06:40
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

@DavideMininni-Fincons DavideMininni-Fincons Awaiting requested review from DavideMininni-Fincons

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomMenga @jeripeierSBB