test: fix freeze on assert fail #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
TomMenga
added
the
pr: lead review required
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
kyubisation
approved these changes
Jun 17, 2024
github-actions
bot
added
pr: lead review approved
github-actions
bot
removed
the
pr: peer review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
The problem was introduced with the update of the
@web/dev-server-corepackage (dependency of@web/test-runner).Specifically, the faulty change is the use of
structuredClone.The
stablefunction is called before reporting the test suite result which contains a reference to the element on which the assertion failed (in our case, the web component, which cannot be cloned).TODO: Open an issue in https://github.com/modernweb-dev/web