Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-accordion, sbb-expansion-panel): add visual test #2751

Merged
merged 10 commits into from
Jun 17, 2024
Merged

test(sbb-accordion, sbb-expansion-panel): add visual test #2751

merged 10 commits into from
Jun 17, 2024

Conversation

TomMenga
Copy link
Contributor

Implemented visual spec tests for:

  • sbb-accordion
  • sbb-expansion-panel
  • sbb-expansion-panel-header
  • sbb-expansion-panel-content (not needed)

@TomMenga TomMenga added the pr: peer review required A peer review is required for this pull request label Jun 13, 2024
@TomMenga TomMenga self-assigned this Jun 13, 2024
@github-actions github-actions bot temporarily deployed to pr2751 June 13, 2024 14:35 Inactive
jeripeierSBB
jeripeierSBB reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good, thank you! I think some snapshot could / should be saved -> see comments

src/elements/expansion-panel/expansion-panel-header/expansion-panel-header.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/expansion-panel/expansion-panel/expansion-panel.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/expansion-panel/expansion-panel/expansion-panel.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2751 June 14, 2024 07:55 Inactive
@github-actions github-actions bot temporarily deployed to pr2751 June 14, 2024 08:23 Inactive
@github-actions github-actions bot temporarily deployed to pr2751 June 14, 2024 11:15 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 14, 2024
@TomMenga TomMenga merged commit 175606d into main Jun 17, 2024
24 of 26 checks passed
@TomMenga TomMenga deleted the visual-spec/accordion branch June 17, 2024 06:57
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jun 17, 2024
@TomMenga TomMenga linked an issue Jun 18, 2024 that may be closed by this pull request
Refactoring: Migration of visual regression tests and testfile restructering #2731
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees

@TomMenga TomMenga

Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring: Migration of visual regression tests and testfile restructering
2 participants
@TomMenga @jeripeierSBB