Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-image): migrate visual regression tests #2737

Merged
merged 3 commits into from
Jun 11, 2024
Merged

test(sbb-image): migrate visual regression tests #2737

merged 3 commits into from
Jun 11, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 11, 2024
@github-actions github-actions bot temporarily deployed to pr2737 June 11, 2024 08:01 Inactive
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jun 11, 2024
kyubisation
kyubisation approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/elements/image/image.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 11, 2024
@jeripeierSBB jeripeierSBB merged commit 9a42c78 into main Jun 11, 2024
21 of 22 checks passed
@jeripeierSBB jeripeierSBB deleted the image-refactoring branch June 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideMininni-Fincons DavideMininni-Fincons DavideMininni-Fincons approved these changes

@TomMenga TomMenga TomMenga approved these changes

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeripeierSBB @kyubisation @TomMenga @DavideMininni-Fincons