-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(selection-panel): improved open/close flow and animation #2360
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
=======================================
Coverage ? 93.55%
=======================================
Files ? 221
Lines ? 23419
Branches ? 2100
=======================================
Hits ? 21909
Misses ? 1474
Partials ? 36 ☔ View full report in Codecov by Sentry. |
7bcb42d
to
f5c032e
Compare
3b6aa91
to
626d133
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now there is an initial animation which should not be there (compare to current version).
Should a panel that uses force-open emit events?
-> In my opinion yes, you don't have to listen to it if you don't care ;)
Should a panel that uses force-open animate?
-> no
I will clarify the current and past situation. Before the update:
I suggest that we keep the same behavior, so:
@jeripeierSBB what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm just not really sure if we should animate the panel if we add the force-open
, but I think it's just a small detail to be confirmed.
@TomMenga sounds good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
This PR aims to solve the problems relative to the open/close events emitted by the
selection-panel
.We have received no complaints, so I expect nobody is using them so far.
Might solve #2309
Changes
css-transition
tocss-animation
. CSS animation provides a more consistent behavior and always emitsanimationend
events.To discuss
force-open
emit events?force-open
animate?