refactor: extract base functionality of list components into NamedSlotListElement
#2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
=======================================
Coverage ? 93.55%
=======================================
Files ? 221
Lines ? 23162
Branches ? 2031
=======================================
Hits ? 21670
Misses ? 1455
Partials ? 37 ☔ View full report in Codecov by Sentry. |
kyubisation
commented
Jan 22, 2024
src/components/core/common-behaviors/named-slot-list-element.ts
Outdated
Show resolved
Hide resolved
kyubisation
commented
Jan 22, 2024
src/components/core/common-behaviors/named-slot-list-element.ts
Outdated
Show resolved
Hide resolved
kyubisation
commented
Jan 22, 2024
kyubisation
force-pushed
the
refactor-list-components
branch
from
6749df5 to
c60dd1c
Compare
kyubisation
force-pushed
the
refactor-list-components
branch
from
e3700bf to
c33510f
Compare
jeripeierSBB
requested changes
Jan 24, 2024
src/components/navigation/navigation-marker/navigation-marker.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the list components, by extracting the common functionality into the
NamedSlotListElementbase class.It also refactors the
SlotChildObserverto be mostly synchronous, instead of asynchronous.