Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce type imports where possible #2348

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a deployment to preview-pr2348 January 17, 2024 09:34 In progress
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@25ede86). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2348   +/-   ##
=======================================
  Coverage        ?   93.69%           
=======================================
  Files           ?      239           
  Lines           ?    24030           
  Branches        ?     2089           
=======================================
  Hits            ?    22514           
  Misses          ?     1479           
  Partials        ?       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot requested a deployment to preview-pr2348 January 17, 2024 10:10 In progress
@jeripeierSBB jeripeierSBB merged commit 276e578 into main Jan 17, 2024
15 checks passed
@jeripeierSBB jeripeierSBB deleted the chore-use-type-imports branch January 17, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants