Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename components with Element suffix #2275

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

kyubisation
Copy link
Contributor

This PR renames the web components with the Element suffix (e.g. SbbAccordion to SbbAccordionElement). This prevents name conflicts when consuming both element and React component (and in the future also Angular component).

This PR renames the web components with the Element suffix (e.g. `SbbAccordion` to
`SbbAccordionElement`). This prevents name conflicts when consuming both element
and React component (and in the future also Angular component).
@kyubisation
Copy link
Contributor Author

@DavideMininni-Fincons, @federicoisepponfincons, @dauriamarco, @MarioCastigliano, @TomMenga Jeri convinced me to rename the components with the Element suffix in order to avoid naming conflicts for consumers and also us in the future. I apologize for not discussing and deciding this with the team. We want to create the "final" Lit release today and are pressed for time. Thank you for your understanding (and feel free to voice your grievances in chat 😄).

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot requested a deployment to preview-pr2275 December 7, 2023 15:16 In progress
@codecov-commenter
Copy link

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (27b023f) 95.99%.
Report is 139 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
src/components/icon/icon-base.ts 89.74% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 95.89% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
...onents/core/eventing/connected-abort-controller.ts 40.00% 3 Missing ⚠️
src/components/form-field/form-field/form-field.ts 82.35% 3 Missing ⚠️
src/components/header/header/header.ts 62.50% 3 Missing ⚠️
... and 22 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2275      +/-   ##
==========================================
+ Coverage   92.61%   95.99%   +3.38%     
==========================================
  Files          53      334     +281     
  Lines        2409    39332   +36923     
  Branches      254     2195    +1941     
==========================================
+ Hits         2231    37756   +35525     
- Misses        176     1532    +1356     
- Partials        2       44      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyubisation kyubisation merged commit 2c4cf25 into master Dec 7, 2023
14 of 16 checks passed
@kyubisation kyubisation deleted the refactor-element-rename branch December 7, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants