Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-notification): fix notification animation #2274

Merged
merged 9 commits into from
Jan 15, 2024
Merged

fix(sbb-notification): fix notification animation #2274

merged 9 commits into from
Jan 15, 2024

Conversation

dauriamarco
Copy link
Contributor

Closes #2257

@dauriamarco dauriamarco self-assigned this Dec 7, 2023
@github-actions github-actions bot requested a deployment to preview-pr2274 December 7, 2023 14:47 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 934a871 to 812cc76 Compare December 7, 2023 21:35
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a64a3eb). Click here to learn what that means.

❗ Current head 33491d2 differs from pull request most recent head 4e409a4. Consider uploading reports for the commit 4e409a4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2274   +/-   ##
=======================================
  Coverage        ?   93.71%           
=======================================
  Files           ?      239           
  Lines           ?    24402           
  Branches        ?     2157           
=======================================
  Hits            ?    22869           
  Misses          ?     1490           
  Partials        ?       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2274 December 7, 2023 21:45 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 812cc76 to 2e6e597 Compare December 11, 2023 10:04
@github-actions github-actions bot requested a deployment to preview-pr2274 December 11, 2023 10:13 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 2e6e597 to 4d6e60d Compare December 11, 2023 13:07
@github-actions github-actions bot requested a deployment to preview-pr2274 December 11, 2023 13:20 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 4d6e60d to 2da52a0 Compare December 12, 2023 10:26
@github-actions github-actions bot requested a deployment to preview-pr2274 December 12, 2023 10:35 In progress
jeripeierSBB
jeripeierSBB reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly Chromatic problem still open. something is weird with the notification since lit migration :D

src/components/notification/notification.ts Show resolved Hide resolved
src/components/notification/notification.scss Outdated Show resolved Hide resolved
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 0ad575e to a08493b Compare December 18, 2023 10:52
@github-actions github-actions bot requested a deployment to preview-pr2274 December 18, 2023 11:01 In progress
@github-actions github-actions bot requested a deployment to preview-pr2274 December 18, 2023 11:19 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 648aa69 to 3df3311 Compare December 18, 2023 15:24
@github-actions github-actions bot requested a deployment to preview-pr2274 December 18, 2023 15:34 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 3df3311 to cbb91e6 Compare December 19, 2023 10:42
@github-actions github-actions bot requested a deployment to preview-pr2274 December 19, 2023 10:52 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from cbb91e6 to 6c16d58 Compare December 20, 2023 09:48
@github-actions github-actions bot requested a deployment to preview-pr2274 December 20, 2023 09:58 In progress
@github-actions github-actions bot requested a deployment to preview-pr2274 December 20, 2023 10:37 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 9392295 to 994a04a Compare December 20, 2023 10:54
@github-actions github-actions bot requested a deployment to preview-pr2274 December 20, 2023 11:04 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 994a04a to 6c16d58 Compare January 3, 2024 08:46
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 6c16d58 to af0907b Compare January 3, 2024 09:08
@github-actions github-actions bot requested a deployment to preview-pr2274 January 3, 2024 09:25 In progress
@github-actions github-actions bot requested a deployment to preview-pr2274 January 8, 2024 10:58 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 6baa70b to 5bb24aa Compare January 12, 2024 13:25
@github-actions github-actions bot requested a deployment to preview-pr2274 January 12, 2024 13:34 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 5bb24aa to e80c86f Compare January 15, 2024 10:03
@github-actions github-actions bot requested a deployment to preview-pr2274 January 15, 2024 10:21 In progress
@dauriamarco dauriamarco force-pushed the fix/notification-animation branch from 33491d2 to 4e409a4 Compare January 15, 2024 10:36
@github-actions github-actions bot requested a deployment to preview-pr2274 January 15, 2024 10:45 In progress
jeripeierSBB
jeripeierSBB approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dauriamarco dauriamarco merged commit 5272043 into main Jan 15, 2024
15 checks passed
@dauriamarco dauriamarco deleted the fix/notification-animation branch January 15, 2024 11:53
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees

@dauriamarco dauriamarco

Labels
preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(sbb-notification): animation stucks
3 participants
@dauriamarco @codecov-commenter @jeripeierSBB