Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-select): adapt setup to work with Next.js hydration #2270

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

kyubisation
Copy link
Contributor

<sbb-select> causes a hydration error in Next.js. This PR implements a workaround by using the render logic of @lit/react to run our setup logic only after Next.js hydration or directly, if not in a Next.js environment.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a deployment to preview-pr2270 December 7, 2023 13:24 In progress
@kyubisation kyubisation merged commit be8a5c5 into master Dec 7, 2023
13 of 15 checks passed
@kyubisation kyubisation deleted the fix-select-hydration branch December 7, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants