Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix datepicker initialization #2266

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a deployment to preview-pr2266 December 6, 2023 14:23 In progress
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (70b0605) 95.95%.
Report is 133 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
src/components/icon/icon-base.ts 89.74% 8 Missing ⚠️
...metable-occupancy-icon/timetable-occupancy-icon.ts 92.66% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 86.95% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
...onents/core/eventing/connected-abort-controller.ts 40.00% 3 Missing ⚠️
src/components/form-field/form-field/form-field.ts 76.92% 3 Missing ⚠️
... and 26 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2266      +/-   ##
==========================================
+ Coverage   92.61%   95.95%   +3.34%     
==========================================
  Files          53      334     +281     
  Lines        2409    39191   +36782     
  Branches      254     2188    +1934     
==========================================
+ Hits         2231    37605   +35374     
- Misses        176     1542    +1366     
- Partials        2       44      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/components/datepicker/datepicker/datepicker.spec.ts Outdated Show resolved Hide resolved
src/components/datepicker/datepicker/datepicker.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Lukas Spirig <[email protected]>
@github-actions github-actions bot requested a deployment to preview-pr2266 December 6, 2023 15:15 In progress
@jeripeierSBB jeripeierSBB merged commit cc23aff into master Dec 6, 2023
15 checks passed
@jeripeierSBB jeripeierSBB deleted the fix-datepicker-iniz branch December 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants