Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move ref to the back of declarations #2243

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

jeripeierSBB
Copy link
Contributor

With lit SSR, blocks in attributes that do not generate attributes seem to cause faulty rendering. E.g. skipping attributes or assigning wrong values.

With lit ssr blocks in attributes that do not generate attributes seem to cause faulty rendering.
E.g. skipping attributes or assigning wrong values.
Copy link
Contributor

@dauriamarco dauriamarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kyubisation kyubisation merged commit a6ddbc4 into master Nov 30, 2023
14 of 16 checks passed
@kyubisation kyubisation deleted the fix-ref-order branch November 30, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants