fix(sbb-dialog, sbb-menu, sbb-navigation, sbb-tooltip): fix reading order for VoiceOver with Safari #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2106 +/- ##
===========================================
- Coverage 54.85% 36.41% -18.44%
===========================================
Files 49 288 +239
Lines 1659 10972 +9313
Branches 406 2397 +1991
===========================================
+ Hits 910 3996 +3086
- Misses 671 6707 +6036
- Partials 78 269 +191
... and 239 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dauriamarco
reviewed
Oct 24, 2023
dauriamarco
reviewed
Oct 24, 2023
jeripeierSBB
changed the title
jeripeierSBB
changed the title
jeripeierSBB
force-pushed
the
overlay-rework
branch
from
a9c5884 to
7fa5f2a
Compare
jeripeierSBB
commented
Oct 25, 2023
jeripeierSBB
changed the title
jeripeierSBB
changed the title
jeripeierSBB
changed the title
jeripeierSBB
changed the title
jeripeierSBB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beside the main fix for the reading order in Safari with VoiceOver, we removed the role=group from the sbb-dialog and replaced it with a custom announcing logic. Moreover we could remove some existing workarounds and fixed a small bug in high contrast mode of the
sbb-navigation.Closes #2015, #1879, #1880
BREAKING CHANGE:
accessibilityLabelof thesbb-navigationwas removed. As replacement, anaria-labelcan now directly be placed on thesbb-navigationelement.